[SecuritySolution][Navigation] Classic nav updates by ashokaditya · Pull Request #260429 · elastic/kibana

ashokaditya · 2026-03-31T10:12:37Z

Summary

All changes are gated behind a xpack.securitySolution.enableExperimental flag called securityClassicNavUpdate
Adds changes to the classic nav:

Moves Get started, Siem Readiness, Value Report, Manage Automatic Migrations, Translated Rules, Translated Dashboards within Launchpad
Updates the link item UI ( single element with a right chevron for items with sub-nav)
Removes sub panel nav open for Dashboard
Removes landing page navigation on nav item click for links with sub-nav

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

and remove landing page navigation interation from top level nav links refs elastic/security-team#16454 elastic/security-team#16455

refs elastic/security-team#16456

kqualters-elastic · 2026-04-01T19:55:12Z

  const navLinks = useNavLinks();
  const getSecuritySolutionLinkProps = useGetSecuritySolutionLinkProps(); // adds href and onClick props

+  const classicFooterItems = useMemo((): SolutionSideNavItem[] | null => {


This logic is only needed because of the feature flag right? imo with how many different variations of the nav already exist, creating yet another one is not worth the effort/chance of introducing bugs, and it should be kept as declarative as possible. I'm fine with the flag and all the logic it adds if it's necessary, but doesn't really seem so to me.

kqualters-elastic · 2026-04-06T18:29:44Z

-    },
  ];
+
+  return securityClassicNavUpdate


I think if the feature flag is false, you'll still want these links to appear as before, no? The nav in that case will jump from Intelligence to Get Started, with siemReadiness, aiValue, and siemMigrationsLanding all completely missing, which is causing the cypress tests to fail.

FF off, 3 links missing:

Before these changes:

refs 90857a8

refs e6cfa3d

….com:ashokaditya/kibana into task/security-deployment-classic-nav-udpates

kqualters-elastic

desk tested and everything seems to work as expected now, lgtm 👍

elasticmachine · 2026-04-08T06:36:05Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 8c59d81

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #127 / Entity Analytics - Risk Score Maintainer @ess @serverless @serverlessQA Risk Score Maintainer Task Lifecycle with auditbeat data @skipInServerlessMKI produces additional scores after stop and restart
[job] [logs] FTR Configs #50 / Solution navigation smoke tests search solution sidenav & breadcrumbs renders the correct nav and navigate to links

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/security-solution-side-nav`	23	24	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	11.7MB	11.6MB	-8.5KB
`streamsApp`	1.9MB	1.9MB	+24.0B
total			-8.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`elasticAssistant`	272.6KB	272.6KB	+24.0B
`securitySolution`	129.6KB	142.7KB	+13.1KB
`securitySolutionEss`	37.1KB	37.1KB	+24.0B
`securitySolutionServerless`	49.1KB	49.1KB	+24.0B
total			+13.2KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/security-solution-side-nav`	29	32	+3

History

💔 Build #423690 failed 36603c5
💔 Build #423526 failed cc9752c
💔 Build #423471 failed c5ffc21
💛 Build #423163 was flaky 333665b
💔 Build #423076 failed 735473b
💔 Build #423005 failed dc9f1d4

cc @ashokaditya

refs elastic#260429

## Summary Enables classic nav updates added in #260429 for `9.4`. - [x] `securityClassicNavUpdate` feature flag is set to `true` - [x] updated related tests that should now expect elements from the new nav changes <img width="512" height="421" alt="Screenshot 2026-04-14 at 10 39 02" src="https://github.com/user-attachments/assets/526cfa5a-1a61-43c5-b1fa-fdb828fb0e83" /> <img width="512" height="349" alt="Screenshot 2026-04-14 at 10 39 28" src="https://github.com/user-attachments/assets/1038cac2-443f-4456-9744-c7a7a6ada8a2" /> **Note:** There will be a follow up PR for the following BC to remove the feature flag and make the feature flag logic permanent on `main` and `9.4`. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

…2358) ## Summary Enables classic nav updates added in elastic#260429 for `9.4`. - [x] `securityClassicNavUpdate` feature flag is set to `true` - [x] updated related tests that should now expect elements from the new nav changes <img width="512" height="421" alt="Screenshot 2026-04-14 at 10 39 02" src="https://github.com/user-attachments/assets/526cfa5a-1a61-43c5-b1fa-fdb828fb0e83" /> <img width="512" height="349" alt="Screenshot 2026-04-14 at 10 39 28" src="https://github.com/user-attachments/assets/1038cac2-443f-4456-9744-c7a7a6ada8a2" /> **Note:** There will be a follow up PR for the following BC to remove the feature flag and make the feature flag logic permanent on `main` and `9.4`. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit f9bf4a3) # Conflicts: # x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/explore/navigation/navigation.cy.ts

) (#263260) # Backport This will backport the following commits from `main` to `9.4`: - [[SecuritySolution][Navigation] Enable classic nav updates (#262358)](#262358)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

…#263110) ## Summary > [!Caution] > This should be merged on/after `16th Apr` so it is ready for BC3 (23rd Apr) Remove feature flag and enable classic nav unconditionally. related to #260429. FF was enabled for BC2 in #262358 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

…elastic#263110) ## Summary > [!Caution] > This should be merged on/after `16th Apr` so it is ready for BC3 (23rd Apr) Remove feature flag and enable classic nav unconditionally. related to elastic#260429. FF was enabled for BC2 in elastic#262358 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit 6a35d30)

elasticmachine · 2026-04-20T19:11:10Z

Pinging @elastic/security-solution (Team: SecuritySolution)

ashokaditya self-assigned this Mar 31, 2026

ashokaditya added 9.4.0 release_note:enhancement backport:skip This PR does not require backporting labels Mar 31, 2026

ashokaditya force-pushed the task/security-deployment-classic-nav-udpates branch 2 times, most recently from 5021dc2 to 546e271 Compare March 31, 2026 14:57

ashokaditya added 3 commits April 1, 2026 14:27

add launchpad to classic nav with sub links

567e3b6

and remove landing page navigation interation from top level nav links refs elastic/security-team#16454 elastic/security-team#16455

remove dashboard sub nav panel open

99ff01c

refs elastic/security-team#16456

fix feature flagged breadcrumbs and links

c82b2ee

ashokaditya force-pushed the task/security-deployment-classic-nav-udpates branch 2 times, most recently from 295d91a to a94dec0 Compare April 1, 2026 12:37

tests

55fd026

ashokaditya force-pushed the task/security-deployment-classic-nav-udpates branch from a94dec0 to 55fd026 Compare April 1, 2026 13:39

ashokaditya marked this pull request as ready for review April 1, 2026 14:35

ashokaditya requested review from a team as code owners April 1, 2026 14:35

ashokaditya added 2 commits April 1, 2026 18:03

cleanup tests

67d6b15

fix

598cc82

ashokaditya force-pushed the task/security-deployment-classic-nav-udpates branch from 81bc69c to 598cc82 Compare April 1, 2026 18:39

kqualters-elastic reviewed Apr 1, 2026

View reviewed changes

rayafratkina added v9.4.0 and removed 9.4.0 labels Apr 2, 2026

ashokaditya and others added 2 commits April 6, 2026 09:55

Merge branch 'main' into task/security-deployment-classic-nav-udpates

418edf7

update bundle limit for security_solution

6fdb608

ashokaditya requested a review from a team as a code owner April 6, 2026 08:17

Changes from node scripts/eslint_all_files --no-cache --fix

8f9a24e

jbudz approved these changes Apr 6, 2026

View reviewed changes

kqualters-elastic reviewed Apr 6, 2026

View reviewed changes

ashokaditya added 2 commits April 7, 2026 08:53

fix

ef71199

add test for feature flagged nav version

e6cfa3d

ashokaditya and others added 2 commits April 7, 2026 10:04

Merge branch 'main' into task/security-deployment-classic-nav-udpates

90857a8

fix bad merge

dc9f1d4

refs 90857a8

ashokaditya requested a review from kqualters-elastic April 7, 2026 08:34

ashokaditya and others added 3 commits April 7, 2026 11:29

redo test files

735473b

refs e6cfa3d

fix: path

333665b

Merge branch 'main' into task/security-deployment-classic-nav-udpates

d09702f

kqualters-elastic reviewed Apr 7, 2026

View reviewed changes

Comment thread x-pack/solutions/security/plugins/security_solution/public/onboarding/links.ts

kqualters-elastic reviewed Apr 7, 2026

View reviewed changes

Comment thread ...ecurity_solution/public/common/components/navigation/security_side_nav/security_side_nav.tsx Outdated

ashokaditya added 2 commits April 7, 2026 20:05

add manage automatic migrations to launchpad

c767b39

Merge branch 'task/security-deployment-classic-nav-udpates' of github…

c5ffc21

….com:ashokaditya/kibana into task/security-deployment-classic-nav-udpates

ashokaditya requested a review from kqualters-elastic April 7, 2026 18:21

kqualters-elastic approved these changes Apr 7, 2026

View reviewed changes

ashokaditya enabled auto-merge (squash) April 7, 2026 18:38

ashokaditya and others added 4 commits April 7, 2026 21:23

Merge branch 'main' into task/security-deployment-classic-nav-udpates

cc9752c

Merge branch 'main' into task/security-deployment-classic-nav-udpates

07ec795

Merge branch 'main' into task/security-deployment-classic-nav-udpates

36603c5

Merge branch 'main' into task/security-deployment-classic-nav-udpates

8c59d81

ashokaditya merged commit 87d1376 into elastic:main Apr 8, 2026
20 checks passed

ashokaditya deleted the task/security-deployment-classic-nav-udpates branch April 9, 2026 17:53

ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Apr 9, 2026

enable classic nav updates

f720068

refs elastic#260429

ashokaditya mentioned this pull request Apr 9, 2026

[SecuritySolution][Navigation] Enable classic nav updates #262358

Merged

12 tasks

ashokaditya mentioned this pull request Apr 15, 2026

[SecuritySolution][Navigation] Enable updates to Security classic nav #263110

Merged

12 tasks

jmikell821 added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Apr 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecuritySolution][Navigation] Classic nav updates#260429

[SecuritySolution][Navigation] Classic nav updates#260429
ashokaditya merged 22 commits intoelastic:mainfrom
ashokaditya:task/security-deployment-classic-nav-udpates

ashokaditya commented Mar 31, 2026 •

edited

Loading

Uh oh!

kqualters-elastic Apr 1, 2026

Uh oh!

kqualters-elastic Apr 6, 2026

Uh oh!

kqualters-elastic Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

kqualters-elastic left a comment

Uh oh!

Uh oh!

elasticmachine commented Apr 8, 2026

API count

Uh oh!

elasticmachine commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

ashokaditya commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Identify risks

Uh oh!

kqualters-elastic Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

kqualters-elastic Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

kqualters-elastic Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kqualters-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Apr 8, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

elasticmachine commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ashokaditya commented Mar 31, 2026 •

edited

Loading